Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc/ko: Translate INSTALL.md in Korean #1809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

doc/ko: Translate INSTALL.md in Korean #1809

wants to merge 1 commit into from

Conversation

SEOKMIN83
Copy link
Contributor

I have translated the INSTALL.md document for uftrace, which includes a quick usage guide,
descriptions and installation methods for various dependency libraries,
how to build, and how to configure the environment.

@MichelleJin12
Copy link
Contributor

Hello, @SEOKMIN83
Please remove commits that are not related to this PR.

@SEOKMIN83
Copy link
Contributor Author

Hello, @SEOKMIN83
Please remove commits that are not related to this PR.

Sorry, I'll fix it tomorrow.
Thank you for your comment

@honggyukim
Copy link
Collaborator

I've just looked at it roughly. @paranlee @MichelleJin12 Could you review this if the translation is sensible?

@MichelleJin12
Copy link
Contributor

Sure, I will review it and get reviews from other mentees, too.

@honggyukim
Copy link
Collaborator

get reviews from other mentees

That would be nice!

@LouisKimDev
Copy link

The translation looks very good. However I have a suggestion for readability.

108: The uftrace implements its own version of configure script to save user preferences.
97: uftrace는 사용자의 환경 설정을 저장하기 위해 자체적으로 설정 스크립트 버전을 구현합니다.
-> uftrace는 사용자의 환경 설정을 저장하기 위해 자체 버전의 스크립트 설정을 실행합니다.

gichoel
gichoel reviewed Aug 29, 2023
View reviewed changes
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
@SEOKMIN83
Copy link
Contributor Author

The translation looks very good. However I have a suggestion for readability.

108: The uftrace implements its own version of configure script to save user preferences. 97: uftrace는 사용자의 환경 설정을 저장하기 위해 자체적으로 설정 스크립트 버전을 구현합니다. -> uftrace는 사용자의 환경 설정을 저장하기 위해 자체 버전의 스크립트 설정을 실행합니다.

Thank you for comment!!!!
I'll fix this part as you said.

@SEOKMIN83 SEOKMIN83 force-pushed the doc-install branch 2 times, most recently from e15bf21 to 75d7acc Compare September 3, 2023 05:47
@mirusu400
Copy link
Contributor

mirusu400 commented Sep 3, 2023 •
edited
Loading

Could you also update the link in README.md to point to doc/ko/INSTALL.md?

uftrace/doc/ko/README.md

Line 139 in b2e3503

더 자세한 설치방법은, [INSTALL.md](../../INSTALL.md) 파일을 확인하면 된다.

^ here

@MichelleJin12
Copy link
Contributor

Hello, @SEOKMIN83,

Could you update the commit message not to exceed 72 characters per line?
Thank you. :D

MichelleJin12
MichelleJin12 reviewed Sep 16, 2023
View reviewed changes
Copy link
Contributor

@MichelleJin12 MichelleJin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안녕하세요,
한국어 맞춤법 검사기를 사용하여 리뷰하였습니다.
검사기 링크: http://speller.cs.pusan.ac.kr/

그리고

uftrace/doc/ko/uftrace-dump.md

Lines 217 to 219 in 58e7307

번역자
======
민지수 <[email protected]>

이 파일처럼 번역자를 넣으면 좋을 거 같습니다~

doc/ko/INSTALL.md Outdated Show resolved Hide resolved
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
doc/ko/INSTALL.md Outdated Show resolved Hide resolved
@SEOKMIN83 @mirusu400
@LouisKimDev @gichoel
doc/ko: Translate INSTALL.md in Korean
cae3e8f 
I have translated the INSTALL.md documnet for uftrace,
which includes a quick usage guide, descriptions
and installation methods for various dependency libraries, how to build,
and how to configure the environment.
I also modified the link in uftrace/README.md.

Co-authored-by: Seong Jin Kim <[email protected]>
Co-authored-by: Doyun Kim <[email protected]>
Co-authored-by: Gichoel Choi <[email protected]>
Signed-off-by: SeokMin Kwon <[email protected]>
@gichoel
Copy link
Contributor

gichoel commented Oct 26, 2023

Hmm... I guess it's one of those things that got away from our attention while we were waiting for feedback. :)

However, I think we should undo the changes to the English README.md that were made in the current commit, and modify the Korean doc/ko/README.md as follows.

before:

더 자세한 설치방법은, [INSTALL.md](../../INSTALL.md) 파일을 확인하면 된다.

after:

더 자세한 설치방법은, [INSTALL.md](./INSTALL.md) 파일을 확인하면 된다.

Because I think the Korean README.md in the same doc/ko/ directory should link to the Korean INSTALL.md.

@namhyung
Copy link
Owner

Oops, sorry about that. And I agree with @gicheol to link to Korean doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gichoel gichoel gichoel left review comments

@MichelleJin12 MichelleJin12 MichelleJin12 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@SEOKMIN83 @MichelleJin12 @honggyukim @LouisKimDev @mirusu400 @gichoel @namhyung